# HG changeset patch # User Paul Boddie # Date 1423423088 -3600 # Node ID da7fd03fd2ab2402fbc396a30ecebd800068eca8 # Parent 0583da64fbdabb801a95ef69ec59643ab9f1ac6c Fixed missing object updates due to short-circuited evaluation. diff -r 0583da64fbda -r da7fd03fd2ab imip_manager.py --- a/imip_manager.py Sun Feb 08 20:07:47 2015 +0100 +++ b/imip_manager.py Sun Feb 08 20:18:08 2015 +0100 @@ -490,7 +490,7 @@ t = self.handle_date_controls("dtstart") if t: dtstart, attr = t - update = update or self.set_datetime_in_object(dtstart, attr["TZID"], "DTSTART", obj) + update = self.set_datetime_in_object(dtstart, attr["TZID"], "DTSTART", obj) or update else: return False @@ -505,7 +505,7 @@ if not isinstance(dtend, datetime): dtend += timedelta(1) - update = update or self.set_datetime_in_object(dtend, attr["TZID"], "DTEND", obj) + update = self.set_datetime_in_object(dtend, attr["TZID"], "DTEND", obj) or update else: return False @@ -516,7 +516,7 @@ if isinstance(dtstart, datetime): return False dtend = dtstart + timedelta(1) - update = update or self.set_datetime_in_object(dtend, attr["TZID"], "DTEND", obj) + update = self.set_datetime_in_object(dtend, attr["TZID"], "DTEND", obj) or update if dtstart >= dtend: return False